Cache Expensive Index Stats in TransportClusterStatsAction (#63943)#64195
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Oct 27, 2020
original-brownbear:63943-7.x
Merged
Cache Expensive Index Stats in TransportClusterStatsAction (#63943)#64195original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:63943-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:63943-7.x
Conversation
Follow up to #62753, which moved this expensive method off of the transport threads. Often times monitoring will hit this endpoint every few seconds while the metadata will likely change at a much slower interval. Given that in practice the computation of the stats might take up to a minute for large cluster states, caching them on a best-effort basis seems like a reasonable improvement.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Monitoring) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #62753, which moved this expensive method off of the transport threads.
Often times monitoring will hit this endpoint every few seconds while the metadata
will likely change at a much slower interval.
Given that in practice the computation of the stats might take up to a minute for large
cluster states, caching them on a best-effort basis seems like a reasonable improvement.
backport of #63943