Emit a warning when an unknown geo strategy is passed in#63975
Closed
romseygeek wants to merge 1 commit intoelastic:7.xfrom
Closed
Emit a warning when an unknown geo strategy is passed in#63975romseygeek wants to merge 1 commit intoelastic:7.xfrom
romseygeek wants to merge 1 commit intoelastic:7.xfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Contributor
Author
|
This is for 7.x only, as #63836 will make this an error in master. |
Contributor
Author
|
This was handled by the backport of #63836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you set a value other than
termorrecursiveas thedeprecated
strategyparameter on ageo_shapefield, the mapperwill silently fall back to the
recursivestrategy. This commit changesthe parsing logic to emit a deprecation warning when this occurs,
informing the user that a) they're not getting the strategy they were
asking for, and b) this will turn into an error in the near future.