Skip to content

Emit a warning when an unknown geo strategy is passed in#63975

Closed
romseygeek wants to merge 1 commit intoelastic:7.xfrom
romseygeek:geo/strategies-7x
Closed

Emit a warning when an unknown geo strategy is passed in#63975
romseygeek wants to merge 1 commit intoelastic:7.xfrom
romseygeek:geo/strategies-7x

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

Currently if you set a value other than term or recursive as the
deprecated strategy parameter on a geo_shape field, the mapper
will silently fall back to the recursive strategy. This commit changes
the parsing logic to emit a deprecation warning when this occurs,
informing the user that a) they're not getting the strategy they were
asking for, and b) this will turn into an error in the near future.

@romseygeek romseygeek added :Search Foundations/Mapping Index mappings, including merging and defining field types >deprecation v7.11.0 labels Oct 21, 2020
@romseygeek romseygeek requested a review from iverase October 21, 2020 09:19
@romseygeek romseygeek self-assigned this Oct 21, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 21, 2020
@romseygeek
Copy link
Copy Markdown
Contributor Author

This is for 7.x only, as #63836 will make this an error in master.

@romseygeek
Copy link
Copy Markdown
Contributor Author

This was handled by the backport of #63836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>deprecation :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants