Make agg test less confusing (backport of #63952)#63959
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Oct 20, 2020
Merged
Conversation
We have an `@After` annotated method in `AggregatorTestCase` that cleans up releasibles. But it was `private`! Confusingly, it seemed to be working! I'm not sure why. This makes it public which is a little more sensible.
Member
Author
|
run elasticsearch-ci/docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an
@Afterannotated method inAggregatorTestCasethat cleansup releasibles. But it was
private! Confusingly, it seemed to beworking! I'm not sure why. This makes it public which is a little more
sensible.