Skip to content

Standardize runtime field emit methods#61752

Merged
nik9000 merged 1 commit intoelastic:feature/runtime_fieldsfrom
nik9000:script_fields_rename_emit
Aug 31, 2020
Merged

Standardize runtime field emit methods#61752
nik9000 merged 1 commit intoelastic:feature/runtime_fieldsfrom
nik9000:script_fields_rename_emit

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Aug 31, 2020

This standardizes that name for all of the "emit value" methods used by
runtime field scripts to emitValue. To make dates possible this adds a
a toEpochMilli method to convert from TemporalAccessor into millis
since epoch.

@nik9000
Standardize runtime field emit methods
a7dd75f 
This standardizes that name for all of the "emit value" methods used by
runtime field scripts to `emitValue`. To make dates possible this adds a
a `toEpochMilli` method to convert from `TemporalAccessor` into millis
since epoch.
@nik9000 nik9000 added the :Search/Search Search-related issues that do not fall into other categories label Aug 31, 2020
@nik9000 nik9000 requested a review from javanna August 31, 2020 18:22
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Aug 31, 2020

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 31, 2020
@javanna javanna mentioned this pull request Aug 31, 2020
Closed
30 tasks
javanna
javanna approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one question: with this every context supports one return type, and some types require conversions through specific function calls to adapt values to the required return type? I guess with this I am double checking that emitValue always and only accept one argument type per context.

@nik9000
Copy link
Copy Markdown
Member Author

nik9000 commented Aug 31, 2020

with this every context supports one return type, and some types require conversions through specific function calls to adapt values to the required return type? I guess with this I am double checking that emitValue always and only accept one argument type per context.

All correct. Painless itself doesn't have support for arguments with different types so we just pick a "native" type for each.

@nik9000 nik9000 merged commit 0284f3d into elastic:feature/runtime_fields Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@javanna javanna javanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nik9000 @elasticmachine @javanna