Add a consistent way to parse dates#61105
Merged
nik9000 merged 6 commits intoelastic:feature/runtime_fieldsfrom Aug 17, 2020
Merged
Add a consistent way to parse dates#61105nik9000 merged 6 commits intoelastic:feature/runtime_fieldsfrom
nik9000 merged 6 commits intoelastic:feature/runtime_fieldsfrom
Conversation
This adds a `parse` method to `date` valued `runtime_script`s that converts any `Object` into a `long` using the same mechanism that indexing a `date` uses. We also use this new method to expand our test that run's core's integration tests against runtime fields to `date` values fields. Previously we couldn't do that because we didn't have a consistent way to parse the field.
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
parsemethod todatevaluedruntime_scripts thatconverts any
Objectinto alongusing the same mechanism thatindexing a
dateuses.We also use this new method to expand our test that run's core's
integration tests against runtime fields to
datevalues fields.Previously we couldn't do that because we didn't have a consistent way
to parse the field.