Format support for script doc fields#60465
Merged
nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom Aug 3, 2020
Merged
Format support for script doc fields#60465nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom
nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom
Conversation
Adds `format` and `locale` support to `runtime_script` fields, specifically those with the `runtime_type` of `date`. Others `runtime_type`s will return an error if provided with those parameters.
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
30 tasks
javanna
approved these changes
Jul 31, 2020
Contributor
javanna
left a comment
There was a problem hiding this comment.
left a couple of comments, LGTM otherwise
| MapperParsingException.class, | ||
| () -> createIndex("test", Settings.EMPTY, mapping(runtimeType, b -> b.field("format", "yyyy-MM-dd"))) | ||
| ); | ||
| assertThat(e.getMessage(), equalTo("Failed to parse mapping: format not supported by runtime_type [" + runtimeType + "]")); |
Contributor
There was a problem hiding this comment.
nit: I think that looking at this error message, there is a slight change that it makes users think that the specific value they provided for the format parameter is not supported, more than providing any format. same for locale. Maybe we can rephrase it?
| private void checkBadDate(ThrowingRunnable queryBuilder) { | ||
| Exception e = expectThrows(ElasticsearchParseException.class, queryBuilder); | ||
| assertThat(e.getMessage(), containsString("failed to parse date field")); | ||
| } |
Contributor
There was a problem hiding this comment.
would it make sense to have some duel tests between concrete dates and runtime dates to make sure that formatting and locale are applied the same way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
formatandlocalesupport toruntime_scriptfields,specifically those with the
runtime_typeofdate. Othersruntime_types will return an error if provided with those parameters.Relates to #59332