Standardize script field's rejection error#60029
Merged
nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom Jul 22, 2020
Merged
Standardize script field's rejection error#60029nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom
nik9000 merged 3 commits intoelastic:feature/runtime_fieldsfrom
Conversation
This standardizes the exception type thrown when attempting to build a query on a script field that it doesn't support. It also replaces the field type `[script]` in the error message with whatever the runtime type is.
30 tasks
javanna
approved these changes
Jul 22, 2020
Contributor
javanna
left a comment
There was a problem hiding this comment.
left one comment, LGTM otherwise
| QueryShardContext context | ||
| ) { | ||
| throw new IllegalArgumentException( | ||
| "Can only use regexp queries on keyword and text fields - not on [" + name() + "] which is of type [" + runtimeType() + "]" |
Contributor
There was a problem hiding this comment.
To be more accurate, the field is of type script and its runtime_type is keyword, long etc. Can we expand and say it is a script field with runtime_type etc. ?
javanna
reviewed
Jul 22, 2020
| } | ||
|
|
||
| private String unsupported(String query, String supported) { | ||
| String thisField = "[" + name() + "] which is of type [script] with runtime_type [" + runtimeType() + "]"; |
Contributor
There was a problem hiding this comment.
don't hardcode script :) we are going to rename it and if you use the existing constant renaming will be easier
javanna
approved these changes
Jul 22, 2020
Contributor
javanna
left a comment
There was a problem hiding this comment.
LGTM besides the minor comment I left
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This standardizes the exception type thrown when attempting to build a
query on a script field that it doesn't support. It also replaces the
field type
[script]in the error message with whatever the runtime typeis.