Fix TODO about Spurious FAILED Snapshots (#58994)#59576
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Jul 14, 2020
original-brownbear:58994-7.x
Merged
Fix TODO about Spurious FAILED Snapshots (#58994)#59576original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:58994-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:58994-7.x
Conversation
There is no point in writing out snapshots that contain no data that can be restored whatsoever. It may have made sense to do so in the past when there was an `INIT` snapshot step that wrote data to the repository that would've other become unreferenced, but in the current day state machine without the `INIT` step there is no point in doing so.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point in writing out snapshots that contain no data that can be restored
whatsoever. It may have made sense to do so in the past when there was an
INITsnapshotstep that wrote data to the repository that would've other become unreferenced, but in the
current day state machine without the
INITstep there is no point in doing so.backport of #58994