Remove Dead Code from Closed Index Snapshot Logic (#56764)#59398
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Jul 13, 2020
original-brownbear:56764-7.x
Merged
Remove Dead Code from Closed Index Snapshot Logic (#56764)#59398original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:56764-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:56764-7.x
Conversation
The code path for closed indices is dead code here ever since #39644 because `shards(currentState, indexIds, ...)` does not set `MISSING` on a closed index's shard that is assigned any longer. Before that change it would always set `MISSING` for a closed index's shard even it was assigned. => simplified the code accordingly.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code path for closed indices is dead code here ever since #39644
because
shards(currentState, indexIds, ...)does not setMISSINGon a closed index's shard that is assigned any longer. Before that change it would always setMISSINGfor a closed index's shard even it was assigned.=> simplified the code accordingly.
backport of #56764