Skip to content

[DOCS] Document @timestamp as only valid DS timestamp field#59225

Merged
jrodewig merged 3 commits intoelastic:masterfrom
jrodewig:docs__update-ds-timestamp-field
Jul 8, 2020
Merged

[DOCS] Document @timestamp as only valid DS timestamp field#59225
jrodewig merged 3 commits intoelastic:masterfrom
jrodewig:docs__update-ds-timestamp-field

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Jul 8, 2020

Updates the existing data stream docs to fix @timestamp as the only allowed timestamp field.
Relates to #59076.

@jrodewig jrodewig added >docs General docs changes v8.0.0 :StorageEngine/Data streams Data streams and their lifecycles v7.9.0 labels Jul 8, 2020
@jrodewig jrodewig requested review from dakrone and martijnvg July 8, 2020 13:13
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Data streams)

@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Jul 8, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 8, 2020
@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jul 8, 2020

@elasticmachine update branch

@elasticmachine
Copy link
Copy Markdown
Collaborator

merge conflict between base and head

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jul 8, 2020

@elasticmachine update branch

@elasticmachine
Copy link
Copy Markdown
Collaborator

merge conflict between base and head

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one minor comment but not a big deal or anything

Comment on lines +26 to +27
TIP: We recommend using the {ecs-ref}[Elastic Common Schema
(ECS)], which includes the `@timestamp` field.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems strange to say that we recommend @timestamp, since we require it to be @timestamp currently

@jrodewig jrodewig merged commit 30be215 into elastic:master Jul 8, 2020
@jrodewig jrodewig deleted the docs__update-ds-timestamp-field branch July 8, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants