Add Check for Metadata Existence in BlobStoreRepository (#59141)#59216
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Jul 8, 2020
original-brownbear:59141-7.x
Merged
Add Check for Metadata Existence in BlobStoreRepository (#59141)#59216original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:59141-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:59141-7.x
Conversation
In order to ensure that we do not write a broken piece of `RepositoryData` because the phyiscal repository generation was moved ahead more than one step by erroneous concurrent writing to a repository we must check whether or not the current assumed repository generation exists in the repository physically. Without this check we run the risk of writing on top of stale cached repository data. Relates #56911
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to ensure that we do not write a broken piece of
RepositoryDatabecause the phyiscal repository generation was moved ahead more than one step
by erroneous concurrent writing to a repository we must check whether or not
the current assumed repository generation exists in the repository physically.
Without this check we run the risk of writing on top of stale cached repository data.
Relates #56911
backport of #59141