Fix types deprecation warning for put mapping.#58764
Merged
jtibshirani merged 2 commits intoelastic:6.8from Jun 30, 2020
Merged
Fix types deprecation warning for put mapping.#58764jtibshirani merged 2 commits intoelastic:6.8from
jtibshirani merged 2 commits intoelastic:6.8from
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestPutMappingAction.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mayya-sharipova this is now ready for another look, apologies for the false start earlier! |
mayya-sharipova
approved these changes
Jun 30, 2020
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jtibshirani Thanks, makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #38825, we switched from issuing a types warning if
include_type_nameismissing or
true, to only issuing a warning wheninclude_type_nameismissing. However we missed the 'put mapping' API in that PR.
Addresses #58675.