Save memory when parent and child are not on top (backport #57892)#57944
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Jun 10, 2020
Merged
Save memory when parent and child are not on top (backport #57892)#57944nik9000 merged 1 commit intoelastic:7.xfrom
nik9000 merged 1 commit intoelastic:7.xfrom
Conversation
Reworks the `parent` and `child` aggregation are not at the top level using the optimization from elastic#55873. Instead of wrapping all non-top-level `parent` and `child` aggregators we now handle being a child aggregator in the aggregator, specifically by adding recording which global ordinals show up in the parent and then checking if they match the child.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the
parentandchildaggregation are not at the top levelusing the optimization from #55873. Instead of wrapping all
non-top-level
parentandchildaggregators we now handle being achild aggregator in the aggregator, specifically by adding recording
which global ordinals show up in the parent and then checking if they
match the child.