Remove deprecated wrapped from scripted_metric (backport of #57627)#57763
Merged
nik9000 merged 2 commits intoelastic:7.xfrom Jun 5, 2020
Merged
Remove deprecated wrapped from scripted_metric (backport of #57627)#57763nik9000 merged 2 commits intoelastic:7.xfrom
nik9000 merged 2 commits intoelastic:7.xfrom
Conversation
…7627) This removes the deprecated `asMultiBucketAggregator` wrapper from `scripted_metric`. Unlike most other such removals, this isn't likely to save much memory. But it does make the internals of the aggregator slightly less twisted. Relates to elastic#56487
scripts don't have permission to call `parallelStream` because it'll sometimes make a fork/join pool and script can't start threads. In this case I added it by accident in elastic#57627 and should have just used `stream`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the deprecated
asMultiBucketAggregatorwrapper fromscripted_metric. Unlike most other such removals, this isn't likely tosave much memory. But it does make the internals of the aggregator
slightly less twisted.
Relates to #56487