Save memory when histogram agg is not on top (backport of #57277)#57377
Merged
nik9000 merged 2 commits intoelastic:7.xfrom May 29, 2020
Merged
Save memory when histogram agg is not on top (backport of #57277)#57377nik9000 merged 2 commits intoelastic:7.xfrom
nik9000 merged 2 commits intoelastic:7.xfrom
Conversation
This saves some memory when the `histogram` aggregation is not a top level aggregation by dropping `asMultiBucketAggregator` in favor of natively implementing multi-bucket storage in the aggregator. For the most part this just uses the `LongKeyedBucketOrds` that we built the first time we did this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves some memory when the
histogramaggregation is not a toplevel aggregation by dropping
asMultiBucketAggregatorin favor ofnatively implementing multi-bucket storage in the aggregator. For the
most part this just uses the
LongKeyedBucketOrdsthat we built thefirst time we did this.