Make RepositoryData Less Memory Heavy (#55293)#55468
Merged
original-brownbear merged 2 commits intoelastic:7.xfrom Apr 20, 2020
original-brownbear:55293-7.x
Merged
Make RepositoryData Less Memory Heavy (#55293)#55468original-brownbear merged 2 commits intoelastic:7.xfrom original-brownbear:55293-7.x
original-brownbear merged 2 commits intoelastic:7.xfrom
original-brownbear:55293-7.x
Conversation
We don't really need `LinkedHashSet` here. We can assume that all the entries are unique and just use a list and use the list utilities to create the cheapest possible version of the list. Also, this fixes a bug in `addSnapshot` which would mutate the existing linked hash set on the current instance (fortunately this never caused a real world bug) and brings the collection in line with the java docs on its getter that claim immutability.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really need
LinkedHashSethere. We can assume that all theentries are unique and just use a list and use the list utilities to
create the cheapest possible version of the list.
Also, this fixes a bug in
addSnapshotwhich would mutate the existinglinked hash set on the current instance (fortunately this never caused a real world bug)
and brings the collection in line with the java docs on its getter that claim immutability.
backport of #55293