Skip to content

[7.x] [ML] fix bugs with prediction field value settings (#55333)#55394

Merged
benwtrent merged 3 commits intoelastic:7.xfrom
benwtrent:backport/7.x/pr-55333
Apr 17, 2020
Merged

[7.x] [ML] fix bugs with prediction field value settings (#55333)#55394
benwtrent merged 3 commits intoelastic:7.xfrom
benwtrent:backport/7.x/pr-55333

Conversation

@benwtrent
Copy link
Copy Markdown
Member

Backports the following commits to 7.x:

This fixes two unreleased bugs:

1. Prediction value type of `number` might show unexpected classes

Analytics created models may have class labels like `1, 5, 10` (or some collection of discrete, whole numbers). These labels are passed to the inference model config in the `classification_labels` field.

When the predicted value format is `numeric` it should attempt to see if the classification labels are provided and are numeric. If so, use those. If not, use the underlying value.

2. When supplying an update overwrite, inference was losing the default prediction field value. This is because it was not copied over in the copy ctor in the ClassificationConfig.Builder class. 

closes elastic#55332
@benwtrent benwtrent added :ml Machine learning backport labels Apr 17, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Copy Markdown
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit 4be3663 into elastic:7.x Apr 17, 2020
@benwtrent benwtrent deleted the backport/7.x/pr-55333 branch April 17, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :ml Machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants