Introduce mechanism to stub request handling#55091
Merged
Tim-Brooks merged 7 commits intoelastic:masterfrom Apr 14, 2020
Merged
Introduce mechanism to stub request handling#55091Tim-Brooks merged 7 commits intoelastic:masterfrom
Tim-Brooks merged 7 commits intoelastic:masterfrom
Conversation
Currently there is a clear mechanism to stub sending a request through the transport. However, this is limited to testing exceptions on the sender side. This commit reworks our transport related testing infrastructure to allow stubbing request handling on the receiving side.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
ywelsch
reviewed
Apr 14, 2020
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
Looking good. I've left one comment about the adapted recovery test.
server/src/test/java/org/elasticsearch/indices/recovery/IndexRecoveryIT.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/transport/StubbableTransport.java
Outdated
Show resolved
Hide resolved
ywelsch
approved these changes
Apr 14, 2020
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. Please run IndexRecoveryIT in a loop for a while before merge to make sure that we have no flakiness with the new test addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a clear mechanism to stub sending a request through
the transport. However, this is limited to testing exceptions on the
sender side. This commit reworks our transport related testing
infrastructure to allow stubbing request handling on the receiving side.