SQL: drop BASE TABLE type in favour for just TABLE (#54836)#54951
Merged
bpintea merged 1 commit intoelastic:7.xfrom Apr 8, 2020
Merged
SQL: drop BASE TABLE type in favour for just TABLE (#54836)#54951bpintea merged 1 commit intoelastic:7.xfrom
bpintea merged 1 commit intoelastic:7.xfrom
Conversation
* Drop BASE TABLE type in favour for just TABLE This commit drops the table type 'BASE TABLE' and replaces all occurences with just 'TABLE', since his type is wider-used and friendlier to the client applications that query for certain table types in their discovery mode. The 'TABLE' type is also explicitely mentioned by the JDBC and ODBC standards and although other data source-specific types are permitted, older apps will not work well with them. * Refactor table type constants out of IndexType Move SQL_TABLE/_ALIAS out of IndexType, so that they can also be used in that Enum definition. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 70241b5)
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix-docker |
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/SQL) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit drops the table type 'BASE TABLE' and replaces all
occurences with just 'TABLE', since his type is wider-used and
friendlier to the client applications that query for certain table types
in their discovery mode.
The 'TABLE' type is also explicitely mentioned by the JDBC and ODBC
standards and although other data source-specific types are permitted,
older apps will not work well with them.
Move SQL_TABLE/_ALIAS out of IndexType, so that they can also be used in
that Enum definition.
Co-authored-by: Elastic Machine elasticmachine@users.noreply.github.com
(cherry picked from commit 70241b5)