Improve agg reduce tests (backport of #54910)#54914
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Apr 7, 2020
Merged
Conversation
This allows subclasses of `InternalAggregationTestCase` to make a `List` of values to reduce so that it can make values that are realistic *together*. The first use of this is with `InternalTTest` which uses it to make results that don't cause their `sum` field to wrap. It'd likely be useful for a ton of other aggs but just one for now.
Member
Author
|
run elasticsearch-ci/packaging-sample-unix-docker |
Member
Author
|
run elasticsearch-ci/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows subclasses of
InternalAggregationTestCaseto make aListof values to reduce so that it can make values that are realistic
together. The first use of this is with
InternalTTestwhich uses itto make results that don't cause their
sumfield to wrap. It'd likelybe useful for a ton of other aggs but just one for now.