Skip to content

Update policy-definitions.asciidoc#54592

Merged
DanRoscigno merged 6 commits intomasterfrom
DanRoscigno-ILM-node.attr-example
Apr 10, 2020
Merged

Update policy-definitions.asciidoc#54592
DanRoscigno merged 6 commits intomasterfrom
DanRoscigno-ILM-node.attr-example

Conversation

@DanRoscigno
Copy link
Copy Markdown
Contributor

The docs show how to create an ILM policy, but not how to add the attr node.attr.data: warm (or hot).

Yes

Yes

  • If submitting code

No code, strictly docs

This PR adds an example to the ILM instructions. The instructions show how to create a policy, and the policy refers to node.attr.data being hot or warm. I added an example showing how to set the attr in both elasticsearch.yaml and on the commandline.

The docs show how to create an ILM policy, but not how to add the attr `node.attr.data: warm` (or hot).
@DanRoscigno DanRoscigno added >docs General docs changes WIP labels Apr 1, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig requested a review from debadair April 1, 2020 15:48
@DanRoscigno
Copy link
Copy Markdown
Contributor Author

Looking at the preview I see issues:
image

I thought the plus signs would align things under the NOTE block, but I got it wrong. I will look for a working example and make a change.

@DanRoscigno
Copy link
Copy Markdown
Contributor Author

@debadair I am happy with it, I am removing the WIP.

@DanRoscigno DanRoscigno removed the WIP label Apr 1, 2020
@DanRoscigno
Copy link
Copy Markdown
Contributor Author

Hi @debadair
Can I apply a label to this so that it is included in 7.7.0 docs (if I add v7.7.0 is that it?), and is it OK to merge?

@jrodewig
Copy link
Copy Markdown
Contributor

jrodewig commented Apr 9, 2020

@elasticmachine run elasticsearch-ci/docs

Copy link
Copy Markdown
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We do label doc changes with the applicable versions, but the change needs to be backported to those branches to show up in the docs, it's not automatic.

@DanRoscigno DanRoscigno merged commit e05d618 into master Apr 10, 2020
@DanRoscigno DanRoscigno deleted the DanRoscigno-ILM-node.attr-example branch April 10, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants