[7.x] Refactor Percentiles/Ranks aggregation builders and factories (#51887)#54537
Merged
polyfractal merged 2 commits intoelastic:7.xfrom Apr 2, 2020
Merged
Conversation
…c#51887) - Consolidates HDR/TDigest factories into a single factory - Consolidates most HDR/TDigest builder into an abstract builder - Deprecates method(), compression(), numSigFig() in favor of a new unified PercentileConfig object - Disallows setting algo options that don't apply to current algo The unified config method carries both the method and algo-specific setting. This provides a mechanism to reject settings that apply to the wrong algorithm. For BWC the old methods are retained but marked as deprecated, and can be removed in future versions. Co-authored-by: Mark Tozzi <mark.tozzi@gmail.com>
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
85 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51887 to 7.x branch, in preparation for VS refactor
I need to do another pass over this tomorrow to make sure everything is ok to merge. It passed tests locally, and there were only minor conflicts, but this does touch serialization. And an exception changed from 5xx (IllegalStateException) to 4xx (IllegalArgumentException) if I remember correctly.
But I need fresher eyes, so tomorrow :)