Add scripting and missing tests for Terms agg#54128
Open
polyfractal wants to merge 4 commits intoelastic:mainfrom
Open
Add scripting and missing tests for Terms agg#54128polyfractal wants to merge 4 commits intoelastic:mainfrom
polyfractal wants to merge 4 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
26 tasks
andyb-elastic
approved these changes
Mar 25, 2020
Contributor
andyb-elastic
left a comment
There was a problem hiding this comment.
LGTM
Do we want to move all the aggregator tests to using AggregatorTestCase#search / #searchAndReduce? All the places where I've come across IndexSearcher#search they were able to be swapped out I think
...r/src/test/java/org/elasticsearch/search/aggregations/bucket/terms/TermsAggregatorTests.java
Show resolved
Hide resolved
Contributor
Author
|
Finally got back to this 😅 Fixed the scripting test, and went ahead and modernized by using searchAndReduce(). Still a lot of not-so-great conventions in the test but this should help get it more in line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terms had unmapped tests (and unmapped + missing) but not missing on a mapped field, or scripting.
I noticed the terms test uses
indexSearcher.search()directly instead of going through the test classessearchAndReduce(). I started to convert them but it turned into a large project, and wanted these tests sooner than that. So I slapped a TODO on the top and will revisit thesearchAndReduceissue later.