TermsLookup uses ObjectParser for x-content parsing#53733
Merged
romseygeek merged 1 commit intoelastic:masterfrom Mar 19, 2020
Merged
TermsLookup uses ObjectParser for x-content parsing#53733romseygeek merged 1 commit intoelastic:masterfrom
romseygeek merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
approved these changes
Mar 19, 2020
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@romseygeek Thanks, good refactoring, your PR LGTM.
Looks like index, id and path are required parameters for terms lookup. I wonder why our documentation states that they are optional. Should we correct this as well: https://www.elastic.co/guide/en/elasticsearch/reference/master/query-dsl-terms-query.html#query-dsl-terms-lookup-params
Contributor
Author
We should! I'll open a follow-up PR, thanks @mayya-sharipova |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
fromXContentmethod inTermsLookupto use anObjectParserand adds an explicit parsing test.Related to #53731