Add scripting, unmapped, supported-type tests to Boxplot#53435
Add scripting, unmapped, supported-type tests to Boxplot#53435polyfractal merged 5 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
andyb-elastic
left a comment
There was a problem hiding this comment.
LGTM
Only thing I'd suggest (maybe in another pr since these are already on the feature branch) is testing the missing parameter with a field that is mapped, I think all the ones here use an unmapped field
|
Ooh good catch, didn't notice that. I'll go ahead and add to this PR |
|
@elasticmachine update branch |
imotov
left a comment
There was a problem hiding this comment.
For some reason I thought these are not needed for this aggregation since we are testing these code paths already in a few others. But I guess I could have messed up handling here. So, good catch!
|
Yah, it's mostly that we're just dotting i's and crossing t's to make sure the VS refactor, when it merges, doesn't change anything that we didn't expect. So trying to add test parity across all the aggs ahead of time to prevent any surprises :) |
These were added in #53132, but I forgot to merge them to master first 😱
Adds some unit tests for scripting, unmapped fields and "supported types"