Fix GCS Mock Range Downloads (#52804)#52831
Merged
original-brownbear merged 1 commit intoelastic:7.6from Feb 26, 2020
original-brownbear:52804-7.6
Merged
Fix GCS Mock Range Downloads (#52804)#52831original-brownbear merged 1 commit intoelastic:7.6from original-brownbear:52804-7.6
original-brownbear merged 1 commit intoelastic:7.6from
original-brownbear:52804-7.6
Conversation
We were not correctly respecting the download range which lead to the GCS SDK client closing the connection at times. Also, fixes another instance of failing to drain the request fully before sending the response headers. Closes #51446
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not correctly respecting the download range which lead
to the GCS SDK client closing the connection at times.
Also, fixes another instance of failing to drain the request fully before sending the response headers.
Closes #51446
backport of #52804