Add supported type tests for Percentiles/Ranks#52597
Merged
polyfractal merged 1 commit intoelastic:masterfrom Feb 24, 2020
Merged
Add supported type tests for Percentiles/Ranks#52597polyfractal merged 1 commit intoelastic:masterfrom
polyfractal merged 1 commit intoelastic:masterfrom
Conversation
Also makes some tweaks to the test itself: - Makes it final so tests can't accidentally override - Adds specific example docs for the floating points, since they are encoded and some aggs (HDR histo) cannot use negative numbers, so blindly using a random long can encode to a negative - Some reformatting to make it more readable
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
85 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new supported/unsupported type tests in the Percentiles and PercentileRanks aggregator tests. As it turns out, percentiles/ranks support all numerics (including boolean, date) :'(
Also makes some tweaks to the test itself: