Remove setuid,setgid bits on all files in Docker image#51851
Merged
pugnascotia merged 3 commits intoelastic:7.xfrom Feb 13, 2020
Merged
Remove setuid,setgid bits on all files in Docker image#51851pugnascotia merged 3 commits intoelastic:7.xfrom
pugnascotia merged 3 commits intoelastic:7.xfrom
Conversation
This is to mitigate "stackclash" attacks. This is a a very small partial backport from elastic#50277.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
Contributor
|
Thanks a lot @pugnascotia !! |
dliappis
approved these changes
Feb 5, 2020
Contributor
dliappis
left a comment
There was a problem hiding this comment.
LGTM! Did you consider a test for it, or is it too complex?
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a step the docker build that removes the setuid and setgid bits on all files. This is a a very small partial backport from #50277.