Skip to content

Add Cache Range Size setting#51521

Merged
tlrx merged 2 commits intoelastic:feature/searchable-snapshotsfrom
tlrx:add-cache-range-setting
Jan 28, 2020
Merged

Add Cache Range Size setting#51521
tlrx merged 2 commits intoelastic:feature/searchable-snapshotsfrom
tlrx:add-cache-range-setting

Conversation

@tlrx
Copy link
Copy Markdown
Member

@tlrx tlrx commented Jan 28, 2020

Note: this pull request targets the feature/searchable-snapshots branch

This pull request changes the current cache range size from 32kb to 32mb and makes it configurable through a globally defined xpack.searchable.snapshot.cache.range_size setting. This setting is set to low values in unit tests (see #50693 (comment)) but a bit higher values in integration tests so that they don't take too much time to complete.

@tlrx tlrx added >enhancement :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Jan 28, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@tlrx tlrx removed the request for review from 111andre111 January 28, 2020 10:18
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tlrx tlrx merged commit 4c686c1 into elastic:feature/searchable-snapshots Jan 28, 2020
@tlrx tlrx deleted the add-cache-range-setting branch January 28, 2020 12:28
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Jan 28, 2020

Thanks David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants