Skip to content

Unmute SnapshotLifecycleTemplateRegistryTests.testThatNonExistingTemplatesAreAddedImmediately#51496

Merged
andreidan merged 1 commit intoelastic:masterfrom
andreidan:slm-unmute-testThatNonExistingTemplatesAreAddedImmediately
Jan 28, 2020
Merged

Unmute SnapshotLifecycleTemplateRegistryTests.testThatNonExistingTemplatesAreAddedImmediately#51496
andreidan merged 1 commit intoelastic:masterfrom
andreidan:slm-unmute-testThatNonExistingTemplatesAreAddedImmediately

Conversation

@andreidan
Copy link
Copy Markdown
Contributor

The test has been re-designed since the failure spotted on the PR build and I wasn't able to reproduce any flakiness given ~300k runs.

Closes #43950

@andreidan andreidan added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. v8.0.0 labels Jan 27, 2020
@andreidan andreidan requested a review from dakrone January 27, 2020 17:43
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is happy :)

@andreidan andreidan merged commit 0ca5cb8 into elastic:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnapshotLifecycleTemplateRegistryTests.testThatNonExistingTemplatesAreAddedImmediately fails on CI non-reproducibly

4 participants