Remove sync flush logic in Engine#51450
Merged
dnhatn merged 6 commits intoelastic:masterfrom Jan 27, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
Member
Author
|
I think it's fine not to renew sync_id after force merge in 8.0. If the replica is online, then sync_id is not needed as that replica should have established PRRL. And if the replica is offline, copying segment files is perhaps more beneficial than operation-based recovery. I've removed the renewal logic in cd97e6c. |
Member
Author
|
Thanks Yannick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the sync-flush logic in the InternalEngine as we no longer issue new syncIds in 8.0.
Sadly, we need to keep the renewal logic as we should re-issue the syncId if users trigger a force-merge.Relates #50776