Add ranged readBlob to S3BlobContainer#51137
Add ranged readBlob to S3BlobContainer#51137ywelsch merged 9 commits intoelastic:feature/searchable-snapshotsfrom
Conversation
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
left a comment
There was a problem hiding this comment.
LGTM - I left minor comments, most of them can be addressed or ignored as you wish. One is about the name of a blob in a test that needs to be fixed.
...pository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
...pository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
...pository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
...pository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
DaveCTurner
left a comment
There was a problem hiding this comment.
I left a handful of small comments.
I think we should have a test that it is safe to close the stream even if it has not been fully consumed. In earlier experiments we saw some suggestion that the SDK might behave badly if that happens, maybe not recycling the underlying connection properly. If so, we should be sure to consume the whole stream ourselves on close.
...ins/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3RetryingInputStream.java
Show resolved
Hide resolved
...ins/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3RetryingInputStream.java
Outdated
Show resolved
Hide resolved
...pository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
Show resolved
Hide resolved
I've addressed this in ff4361f. It's a larger follow-up change though. |
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM except one minor nit, and apparently there's a test failure too.
Implements
InputStream readBlob(final String blobName, final long position, final int length)on the S3BlobContainer.