Replace bespoke parser for significance heuristics (backport of #50623)#50659
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Jan 6, 2020
Merged
Replace bespoke parser for significance heuristics (backport of #50623)#50659nik9000 merged 1 commit intoelastic:7.xfrom
nik9000 merged 1 commit intoelastic:7.xfrom
Conversation
This replaces the hand written xcontent parsers for significance heristics with `ObjectParser` and parsing named xcontent. As a happy accident, this was the last user of `ParseFieldRegistry` so this PR entirely removes that class. Closes elastic#25519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the hand written xcontent parsers for significance
heristics with
ObjectParserand parsing named xcontent.As a happy accident, this was the last user of
ParseFieldRegistrysothis PR entirely removes that class.
Closes #25519