[7.x] Synchronize processInStream.close() call#50581
Merged
przemekwitek merged 2 commits intoelastic:7.xfrom Jan 3, 2020
Merged
[7.x] Synchronize processInStream.close() call#50581przemekwitek merged 2 commits intoelastic:7.xfrom
przemekwitek merged 2 commits intoelastic:7.xfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
approved these changes
Jan 3, 2020
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Great find!
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to https://bugs.openjdk.java.net/browse/JDK-8054565 the
FilterOutputStreamcannot be closed twice in Java 8.This PR is a workaround for this issue. It needs to be merged only to 7.x branch as in master we use Java 9 which contains the proper fix.
It also unmutes
testStopAndRestarttest case that was suffering from the underlying issue.Relates #49680