Use ClusterState as Consistency Source for Snapshot Repositories (#49060)#50267
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Dec 17, 2019
original-brownbear:49060-7.x
Merged
Use ClusterState as Consistency Source for Snapshot Repositories (#49060)#50267original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:49060-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:49060-7.x
Conversation
) Follow up to #49729 This change removes falling back to listing out the repository contents to find the latest `index-N` in write-mounted blob store repositories. This saves 2-3 list operations on each snapshot create and delete operation. Also it makes all the snapshot status APIs cheaper (and faster) by saving one list operation there as well in many cases. This removes the resiliency to concurrent modifications of the repository as a result and puts a repository in a `corrupted` state in case loading `RepositoryData` failed from the assumed generation.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #49729
This change removes falling back to listing out the repository contents to find the latest
index-Nin write-mounted blob store repositories.This saves 2-3 list operations on each snapshot create and delete operation. Also it makes all the snapshot status APIs cheaper (and faster) by saving one list operation there as well in many cases.
This removes the resiliency to concurrent modifications of the repository as a result and puts a repository in a
corruptedstate in case loadingRepositoryDatafailed from the assumed generation.backport of #49060