Closed
Conversation
Fix testMaxThreadAndMergeCount from failing when the host machine has < 8 cores.
Contributor
Author
|
/cc @jimczi as it looks like you were the original author |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
Contributor
Author
|
@romseygeek maybe you can have a look at this? |
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine update branch |
Contributor
|
@elasticmachine test this please |
Contributor
|
Hi @mattweber, it looks as though this change causes the test in the lines above your change to fail - can you take a look? |
Contributor
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix testMaxThreadAndMergeCount from failing when the host
machine has < 8 cores.
This test kept failing for me since my dev machine only has 4 cores and this test tried to set the
NODE_PROCESSORS_SETTINGto 8 even though it has a max value of the number of cores (4).