Slash missed in indices.put_mapping url#49468
Merged
ezimuel merged 1 commit intoelastic:masterfrom Nov 22, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
Contributor
Author
|
I merged also in 7.x branch. Thanks @karmi. |
Contributor
|
@ezimuel please try to remember to add version labels to PRs so they are included properly int he release notes. I've added the version labels I think are relevant here but please correct them if they are wrong. Thanks |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST API specification of
indices.put_mappingis missing the first slash in the url.This is causing a failure in the code generation of
elasticsearch-php(see elastic/elasticsearch-php#970) and potentially for other clients.This fix should be backported also in 7.x branches.
cc @elastic/es-clients