Blacklist a number of prediction field names.#49371
Closed
przemekwitek wants to merge 2 commits intoelastic:masterfrom
Closed
Blacklist a number of prediction field names.#49371przemekwitek wants to merge 2 commits intoelastic:masterfrom
przemekwitek wants to merge 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Nov 20, 2019
...in/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Classification.java
Show resolved
Hide resolved
benwtrent
approved these changes
Nov 20, 2019
Author
|
Abandoning this PR in favor of elastic/ml-cpp#861 which implements the same logic but in C++. Thanks to this, there is no coupling introduced between C++ and Java wrt ml results format. |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents field name clashes in ml results docs on JSON level.
Closes #48808