Move CI job definitions to this repo by alpar-t · Pull Request #49096 · elastic/elasticsearch

alpar-t · 2019-11-14T15:06:39Z

This PR moves over all CI jobs definitions.
All in all I think it reads much better than what we had before.

Some jobs were combined, e.x. the 3rd party is now a single job.
Oss and default distro bwc tests are now a single job and explicit.
Docs checks are the same, they test both oss and default in a single
job.
I did not add specific PR checks for docs and bwc with the oss distro.
Both will test the default and the oss will be tested lather.
The short-cut to only do a docs check on docs only changes is now also
removed to favor simplicity. The build cache should now be sufficient,
but we can add it back if that's not the case.

I'm submitting this for early feedback. I'll do some more testing and make sure to send out an email to the team before merging.

Closes https://github.com/elastic/infra/issues/15187

elasticmachine · 2019-11-14T15:06:41Z

Pinging @elastic/es-core-infra (:Core/Infra/Build)

rjernst

I left a few comments.

rjernst · 2019-11-14T21:50:57Z

.ci/build.ps1

Why are we taking destructive actions? While I understand we are using ephemeral workers, why does the CI image contain gradle init scripts we don't want to use?

Ephemeral workers don't have anything there, but we still have a few workers that are not ephemeral, and we want to make sure we don't keep old scripts around.
We have to use an init script as that's the only way it will be applicable to all invocations without a lot of boilerplate to pass that around.

rjernst · 2019-11-14T21:54:50Z

.ci/jobs.t/0-packaging-all-windows.yml

Unrelated: Do we have an issue to add a vagrant image for 2019?

Not explicitly. We have an issue to support vagrant as part of the CI image generation. When that happens we'll get all the platforms available in CI as vagrant images

rjernst · 2019-11-14T22:00:14Z

.ci/setup-EAR.sh

Can we have a subdirectory for scripts? This top level directory is beginning to get crowded.

I added it now. os.ps1 and os.sh will need to move after the old jobs that use them are removed.

rjernst · 2019-11-14T22:01:46Z

qa/build.gradle

Is this intentional? If we are to do this, it should be a separate change. Where would we be running these tests with the oss distribution?

Indeed. As I understand it we run everything against OSS and then we have a specific build to use the default distribution. Have we inverted this?

The current jobs no longer assume a default, they pass this in explicitly.
The existing default is not consistent, we have the default distro for docs and oss for the qa directory. I find this to be confusing and hard to reason about coverage when looking at the jobs, so this change makes it consistent that we always default to the default distribution for the sole reason that it's a super set.
You'll see that some of the existing jobs don't have the correct coverage due to this confusion.
I think it's ok to do this as part of this change, because the new jobs do provide the correct coverage and the old ones are meant to go away very soon after we merge this.

mark-vieira

I have a few general questions:

What's the numeric prefix for? Does this influence behavior in some way?
How are these builds going to interact with existing builds that live in the infra repo? How does Jenkins deduplicate builds with the same name, or will they be considered unique because the displayname differs? Is there anyway we could (while things are living side by side) use a different job name prefix so we can put these all under a distinct view?
Speaking of, how do we define views?

mark-vieira · 2019-11-14T22:12:26Z

.ci/build.sh

This should be --build-cache I believe.

mark-vieira · 2019-11-14T22:15:32Z

.ci/jobs.t/1-intake-0-sanity-check.yml

Since we're adding --build-cache in build.sh I think we can ditch it everywhere else.

mark-vieira · 2019-11-14T22:16:32Z

.ci/jobs.t/0-pr-precommit.yml

What's the purpose of this job? Doesn't it overlap with checks part 1 and 2? We don't seem to be doing this in "stages" like we do with intake where we defer the later checks until precommit passes so I'm not sure this helps in catching things more quickly.

This replaces the other tests when the >test-mute label is present.
@mark-vieira since your taking this Pr over, it might be a good idea to add comments explaining what the odd pr builder syntax really means

mark-vieira · 2019-11-14T23:40:12Z

.ci/jobs.t/2-packaging-vagrant.yml

I thought we had decided to ditch the nested virtualization builds? That is what this is, right?

We did, but this is essentially the same job running on bare metal.
It's a replacement for the existing bare metal jobs ( there's an experimental job already running ) . It make better use of the bare metal hardware bu spreading out to more workers.

This PR moves over all CI jobs definitions. Some jobs were combined, e.x. the 3rd party is now a single job. Oss and default distro bwc tests are now a single job and explicit. Docs checks are the same, they test both oss and default in a single job. I did not add specific PR checks for docs and bwc with the oss distro. Both will test the default and the oss will be tested lather. The short-cut to only do a docs check on docs only changes is now also removed to favor simplicity. The build cache should now be sufficient, but we can add it back if that's not the case.

alpar-t · 2019-11-19T08:51:53Z

What's the numeric prefix for? Does this influence behavior in some way?

It does not, it's just to influence the order in which files are listed, I think it makes it a bit easier to think about the jobs.

How are these builds going to interact with existing builds that live in the infra repo? How does Jenkins deduplicate builds with the same name, or will they be considered unique because the displayname differs? Is there anyway we could (while things are living side by side) use a different job name prefix so we can put these all under a distinct view?

We could use a different prefix, and a new view, but I was hoping the switch will be quick enough to make that an overkill. There should be no interaction, all these jobs should have unique names, either one not used or -next added.

Speaking of, how do we define views?
There is a way to define them in this repo, but I left that in the infra repo for now, because that's where know the branches we are interested in a view for.
Creating one for each %BRANCH% would create too many as we have the doc builds on past release branches.

mark-vieira · 2020-01-08T22:16:35Z

I just encountered https://github.com/elastic/infra/issues/17055 with JJBB which is pretty much a blocker for us. I've tried a number of workarounds but cannot successfully get JJBB to configure a job w/ a non-default workspace. Since we rely on using a ramdisk for our build workspace this will need to get sorted out before we migrate.

mark-vieira · 2020-01-22T20:32:52Z

With my limited bandwidth, and the current state of CI, this is simply not a high priority right now. I'm parking this effort for now, in light of other work, as well as the upcoming TeamCity POC which may make this OBE anyway.

mark-vieira · 2020-06-17T16:48:08Z

Closing this since we are beginning our migration to TeamCity which would make migrating to JJBB unnecessary.

alpar-t added the :Delivery/Build Build or test infrastructure label Nov 14, 2019

alpar-t requested review from mark-vieira, pugnascotia and rjernst November 14, 2019 15:06

rjernst reviewed Nov 14, 2019

View reviewed changes

mark-vieira reviewed Nov 14, 2019

View reviewed changes

alpar-t added 4 commits November 15, 2019 16:29

Fix forward testing param

3334019

Move scripts into their own dir

151cd92

Switch remote for testing

54df171

alpar-t force-pushed the move-jobs branch from bb9863d to 54df171 Compare November 15, 2019 23:20

alpar-t added 10 commits November 16, 2019 01:22

Remove email and gcp publishers for testing

a279233

fix typo

56b8038

Only set VAULT_TOKEN if not set

5fc619f

replace JAVA_HOME with BUILD_JAVA home as input

6521df5

Fix command arg line

4676617

Fix display name of intake part 2

fb4ea59

export env vars

9c4a9e9

Fix third party test

7c2d4f3

Use conditional homer notifications

047c698

Fix jdk tests

d98221b

jkakavas mentioned this pull request Nov 22, 2019

Enable tests in FIPS 140 in JDK 11 #49485

Merged

mark-vieira added the stalled label Jan 22, 2020

rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020

mark-vieira closed this Jun 17, 2020

mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020

Conversation

alpar-t commented Nov 14, 2019 • edited by mark-vieira Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 14, 2019

Uh oh!

rjernst left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mark-vieira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alpar-t commented Nov 19, 2019

Uh oh!

mark-vieira commented Jan 8, 2020

Uh oh!

mark-vieira commented Jan 22, 2020

Uh oh!

mark-vieira commented Jun 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alpar-t commented Nov 14, 2019 •

edited by mark-vieira

Loading