Do not ignore exception when trim unreferenced readers#48470
Closed
dnhatn wants to merge 3 commits intoelastic:masterfrom
Closed
Do not ignore exception when trim unreferenced readers#48470dnhatn wants to merge 3 commits intoelastic:masterfrom
dnhatn wants to merge 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
Is there an underlying problem with how this is handled today?
Closing the reader only closes the underlying file channel. Given that the reader is dead/unused info anyway, it seems excessive to fail the translog due to failing to close the channel? Just like we ignore exceptions if we cannot delete the files afterwards.
Member
Author
|
@henningandersen Yes, I agree. It's too harsh to fail translog in this case. Thank you for looking. |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not suppress the exception and fail translog if we fail to close the reader.