Skip to content

Close query cache on index service creation failure#48278

Merged
DaveCTurner merged 2 commits intoelastic:6.8from
DaveCTurner:2019-10-21-backport-48230
Oct 21, 2019
Merged

Close query cache on index service creation failure#48278
DaveCTurner merged 2 commits intoelastic:6.8from
DaveCTurner:2019-10-21-backport-48230

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner commented Oct 21, 2019

Today it is possible that we create the QueryCache and then fail to create
the owning IndexService and this means we do not close the QueryCache
again. This commit addresses that leak.

Fixes #48186

@DaveCTurner
Close query cache on index service creation failure (elastic#48230)
d927b2a 
Today it is possible that we create the `QueryCache` and then fail to create
the owning `IndexService` and this means we do not close the `QueryCache`
again. This commit addresses that leak.

Fixes elastic#48186
@DaveCTurner DaveCTurner added >bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. backport v6.8.5 labels Oct 21, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 21, 2019

Pinging @elastic/es-distributed (:Distributed/CRUD)

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Oct 21, 2019

Transient network issues? Think this'll be fixed by #48249.

Step 4/29 : RUN curl -L --retry 8 -s https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/download/jdk-13%2B33/OpenJDK13U-jdk_x64_linux_hotspot_13_33.tar.gz | tar -C /opt -zxf -
 ---> Running in 3b2ce113f6de
�[91m
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

@elasticmachine please run elasticsearch-ci/1

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Oct 21, 2019

Just™ a backport, no need for a review.

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Oct 21, 2019

Tests failed due to OOM

@elasticmachine please run elasticsearch-ci/2

@DaveCTurner DaveCTurner merged commit b82b3d6 into elastic:6.8 Oct 21, 2019
@DaveCTurner DaveCTurner deleted the 2019-10-21-backport-48230 branch October 21, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport >bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.8.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveCTurner @elasticmachine