Use /api/security/saml/callback as Kibana ACS URL.#47999
Merged
azasypkin merged 1 commit intoelastic:masterfrom Oct 15, 2019
Merged
Use /api/security/saml/callback as Kibana ACS URL.#47999azasypkin merged 1 commit intoelastic:masterfrom
/api/security/saml/callback as Kibana ACS URL.#47999azasypkin merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-security (:Security/Authentication) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Merged
1 task
Contributor
|
There are a lot of these that need to fixed in cloud (ESS/ECE/ ECE RBAC ) docs. It will be definitely more tricky there as we do maintain docs for older versions too |
Contributor
Author
Yeah, we'll need to figure that out anyway, with NP migration in Kibana we may have more of PRs like this one in the near future. |
jkakavas
approved these changes
Oct 15, 2019
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
LGTM, I did a search and we do not seem to be using the v1 urls anywhere else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In elastic/kibana#47929 Kibana dropped
/api/security/v1/saml(deprecated since 7.5) route in favor of/api/security/saml/callback(in 8.0+). In this PR I'm just updating all references to already deprecated/api/security/v1/samlKibana ACS URL.