Ensure random timestamps are within search boundary (#38753)#47787
Merged
cbuescher merged 1 commit intoelastic:7.xfrom Oct 10, 2019
Merged
Ensure random timestamps are within search boundary (#38753)#47787cbuescher merged 1 commit intoelastic:7.xfrom
cbuescher merged 1 commit intoelastic:7.xfrom
Conversation
The random timestamps were landing too close to the current time, so an unlucky rollup interval would round such that the doc wasn't included in the search range (and thus not "rolled up") which would then fail the test. The fix is to make sure the timestamp of all docs is sufficiently behind 'now' that the possible rounding intervals will always include them. Unmutes testRandomizedDateHisto, closes elastic#34762 "Forward-port" of 368c6f2 (wasn't merged into master for some reason)
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Rollup) |
polyfractal
approved these changes
Oct 10, 2019
Contributor
polyfractal
left a comment
There was a problem hiding this comment.
Oops, yes, I think this was just a forgotten backport. Thanks!
Contributor
|
Ah right, there was a mixup at the time when things were merged. It merged into 6.x, but somehow master was forgotten. I think when it was noticed and merged to master, 7.x had been cut and I didn't notice/think about it...so the fix was in 6.x and master but not 7.x. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #38753 to 7.x where the test is still mutes, I thinkt it was just forgotten.
The random timestamps were landing too close to the current time,
so an unlucky rollup interval would round such that the doc wasn't
included in the search range (and thus not "rolled up") which
would then fail the test.
The fix is to make sure the timestamp of all docs is sufficiently behind
'now' that the possible rounding intervals will always include them.