Skip to content

Fix flaky test addSnapshotLifecyclePolicy (#46881)#46912

Merged
andreidan merged 1 commit intoelastic:7.xfrom
andreidan:backport/7x-fix-flaky-testAddSnapshotLifecyclePolicy
Sep 20, 2019
Merged

Fix flaky test addSnapshotLifecyclePolicy (#46881)#46912
andreidan merged 1 commit intoelastic:7.xfrom
andreidan:backport/7x-fix-flaky-testAddSnapshotLifecyclePolicy

Conversation

@andreidan
Copy link
Copy Markdown
Contributor

  • addSnapshotLifecyclePolicy drop version assertion

This drops the assertion on the policy version (which was pinned to 1L)
as we want to execute both put policy apis (sync and async) for
documentation purposes. This will sometimes (depending on the async
call) yield a version of 2L. Waiting for the async call to always
complete could be an option but the test is already rather slow and it's
a bit of an overkill as we're already verifying the policy was created.

(cherry picked from commit af4864c)
Signed-off-by: Andrei Dan andrei.dan@elastic.co

Backport of #46881

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

* addSnapshotLifecyclePolicy drop version assertion

This drops the assertion on the policy version (which was pinned to 1L)
as we want to execute both put policy apis (sync and async) for
documentation purposes. This will sometimes (depending on the async
call) yield a version of 2L. Waiting for the async call to always
complete could be an option but the test is already rather slow and it's
a bit of an overkill as we're already verifying the policy was created.

(cherry picked from commit af4864c)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
@andreidan andreidan merged commit 402fb5e into elastic:7.x Sep 20, 2019
@andreidan andreidan deleted the backport/7x-fix-flaky-testAddSnapshotLifecyclePolicy branch September 20, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant