PKIRealm delegation unsupported without a truststore#45011
Merged
albertzaharovits merged 3 commits intoelastic:proxied-pkifrom Aug 1, 2019
Conversation
Collaborator
|
Pinging @elastic/es-security |
bizybot
approved these changes
Jul 31, 2019
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/pki/PkiRealm.java
Outdated
Show resolved
Hide resolved
…ecurity/authc/pki/PkiRealm.java Co-Authored-By: Yogesh Gaikwad <902768+bizybot@users.noreply.github.com>
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
…tion-without-trustore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the usual scenario, where the
PKIRealmworks without delegation, a trust configuration is not required at the realm settings scope. In this case the client's certificate chain has been validated by the TLS channel (HTTP), and the realm does not enforce any other extra chain validations. In this case the client's certificate is considered authenticated by the realm.This no-op validation, without a trust configuration at the realm level, is incompatible with the delegation use-case. This commit adds a constructor check to the
PKIRealmthat will forbid togglingdelegation.enabledwithout also setting a truststore. Otherwise, the delegation feature would not work at run-time (all API calls will be un-authorized).Thanks Tim for pointing out this problem to me!
Relates #34396