PKI realm usage stats includes delegation#44871
Merged
albertzaharovits merged 5 commits intoelastic:proxied-pkifrom Aug 5, 2019
Merged
PKI realm usage stats includes delegation#44871albertzaharovits merged 5 commits intoelastic:proxied-pkifrom
albertzaharovits merged 5 commits intoelastic:proxied-pkifrom
Conversation
Collaborator
|
Pinging @elastic/es-security |
bizybot
reviewed
Jul 26, 2019
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/pki/PkiRealm.java
Show resolved
Hide resolved
tvernum
reviewed
Jul 26, 2019
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/pki/PkiRealm.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/pki/PkiRealm.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/pki/PkiRealm.java
Outdated
Show resolved
Hide resolved
Contributor
Author
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following fields to the PKI realm's usage stats:
has_truststore,has_delegated_realms,principal_patternandis_authentication_delegated.Purist might cringe since not all the fields added have to do with PKI authn delegation.
I am open to adapt the PR to whatever subset of these you (the reviewer) think it's appropriate for this PR (assuming it includes
is_authentication_delegated).Relates #34396