Custom analysis can't have same names as built-in#43252
Custom analysis can't have same names as built-in#43252mayya-sharipova wants to merge 6 commits intoelastic:mainfrom
Conversation
Do not allow custom analysis components to have the same names as built-in components Closes elastic#22263
|
Pinging @elastic/es-search |
|
I think we should still allow overriding the |
|
@jpountz Thanks for the feedback, Adrien. This has been addressed in the 2n commit. |
|
@mayya-sharipova - a heads-up. I'm about to introduce the first out-of-the-box normalizer ("lowercase") in #53882 Like pre-built analyzers, pre-built normalizers should be something we want to avoid name-clashing with user-defined configurations in index settings. |
|
@markharwood Thank you for the heads-up. I will adjust this PR accordingly |
|
@markharwood I have decided that is better to tackle name clashing for normalizers in a separate PR, and normalizers are absent in |
|
@jpountz Can you please continue the review when you have time. |
|
Hi @mayya-sharipova, I've created a changelog YAML for you. Note that since this PR is labelled |
|
the changelog creation triggered notifcations on some of these old PRs, maybe it's a chance to close them though? :) |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Do not allow custom analysis components to have the same names as
built-in components
Closes #22263