Introduce ShardState Enum + Slight Cleanup SnapshotsInProgress (#41940)#42573
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom May 27, 2019
original-brownbear:41940-7.x
Merged
Introduce ShardState Enum + Slight Cleanup SnapshotsInProgress (#41940)#42573original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:41940-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:41940-7.x
Conversation
* Added separate enum for the state of each shard, it was really confusing that we used the same enum for the state of the snapshot overall and the state of each individual shard * relates #40943 (comment) * Shortened some obvious spots in equals method and saved a few lines via `computeIfAbsent` to make up for adding 50 new lines to this class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confusing that we used the same enum for the state of the snapshot
overall and the state of each individual shard
via
computeIfAbsentto make up for adding 50 new lines to this classback port of #41940