[ML] adding pivot.max_search_page_size option for setting paging size#42079
Merged
benwtrent merged 1 commit intoelastic:7.xfrom May 10, 2019
Merged
Conversation
…elastic#41920) * [ML] adding pivot.size option for setting paging size * Changing field name to address PR comments * fixing ctor usage * adjust hlrc for field name change
Collaborator
|
Pinging @elastic/ml-core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
max_search_page_sizeparameter to thepivotconfiguration in a data frame transform.I put the parameter inside the
pivotconfiguration and not in the root object, as it relates directly to how we are pivoting the data. Since we are unsure what the next transform looks like, I thought it best to restricted it instead of making it atransformfield.If it is
nullwe still opt to use the internal default of500.backport of #41920