Skip to content

[ML] addresses preview bug, and adds check to PUT (#41803)#41850

Merged
benwtrent merged 1 commit intoelastic:7.xfrom
benwtrent:feature/ml-df-preview-bug-fix-7.x
May 6, 2019
Merged

[ML] addresses preview bug, and adds check to PUT (#41803)#41850
benwtrent merged 1 commit intoelastic:7.xfrom
benwtrent:feature/ml-df-preview-bug-fix-7.x

Conversation

@benwtrent
Copy link
Copy Markdown
Member

Bug fixes:

  • NPE error on _preview if source index does not exists
  • NPE error on put if destination index exists and security is enabled

Additionally checks for the following dest.index and source.index are done:

  • That any of the source index names match (simple regex) the dest.index
  • That any of the concrete indices behind the source index names match dest.index
  • That dest.index is NOT a simple regex pattern, and if it exists, is not backed by more than one index
  • If the dest.index exists, that its concrete index is not contained in source.index concrete index names

Backport of #41803

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core

@benwtrent
Copy link
Copy Markdown
Member Author

run elasticsearch-ci/1

@benwtrent benwtrent merged commit 50fc27e into elastic:7.x May 6, 2019
@benwtrent benwtrent deleted the feature/ml-df-preview-bug-fix-7.x branch May 6, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants